Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate various string allocations #769

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Eliminate various string allocations #769

merged 3 commits into from
Feb 13, 2024

Conversation

iamcarbon
Copy link
Contributor

This PR introduces an overload on TextRendererBase that writes a character a specific number of times, and utilizes it to eliminate various string allocations.

MihaZupan
MihaZupan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I wouldn't be surprised if there's more low-hanging fruit around the normalize/roundtrip renderers, I never really looked into them.

@xoofx xoofx merged commit 0014ec4 into xoofx:master Feb 13, 2024
1 check passed
@xoofx
Copy link
Owner

xoofx commented Feb 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamcarbon @xoofx @MihaZupan